Fix 1.1 e2e's to work with 1.2 clusters with scheduler named "default-scheduler" #20740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-github-robot
added
the
size/M
|
Labelling this PR as size/M |
|
GCE e2e build/test failed for commit a7f287cc3ee4dc6b6b9c1fb3dbb7c8034274611f. |
| @@ -100,13 +109,20 @@ func verifyResult(c *client.Client, podName string, ns string, oldNotRunning int | |||
| expectNoError(err) | |||
| _, notRunningPods := getPodsNumbers(allPods) | |||
|
|
|||
| // See comment at top of scheduler_predicates.go | |||
There was a problem hiding this comment.
repeating this three times... maybe this should be a util func?
|
@ixdy PTAL. |
| // It changed the default scheduler name from "scheduler" to | ||
| // "default-scheduler", breaking forward-compatibility with tests that rely on | ||
| // finding events from the default scheduler. | ||
| var multiSchedulerVersion = version.MustParse("v1.2.0-alpha.6") |
There was a problem hiding this comment.
You can't assign a const a function call.
|
needs |
|
GCE e2e test build/test passed for commit 0a36a05e16d4d54078b9e56165e6217f500b4659. |
|
@ixdy |
|
GCE e2e test build/test passed for commit 0511f52. |
|
LGTM |
ixdy
added
the
lgtm
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
GCE e2e test build/test passed for commit 0511f52. |
|
Automatic merge from submit-queue |
k8s-github-robot
pushed a commit
that referenced
this pull request
Feb 9, 2016
Auto commit by PR queue bot
shyamjvs
pushed a commit
to shyamjvs/kubernetes
that referenced
this pull request
Dec 1, 2016
…-release-1.1 Auto commit by PR queue bot
shouhong
pushed a commit
to shouhong/kubernetes
that referenced
this pull request
Feb 14, 2017
…-release-1.1 Auto commit by PR queue bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19724.
Includes a partial cherry-pick of #19608.